Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-3586 - Allow colon in chromosome names #248

Merged
merged 10 commits into from
Jul 2, 2024

Conversation

tcezard
Copy link
Member

@tcezard tcezard commented Jun 14, 2024

Simply allows colon in chromosome names

@@ -1052,7 +1052,7 @@ namespace odb
typedef
sqlite::query_column<
sqlite::value_traits<
::size_t,
long unsigned int,
Copy link
Member Author

@tcezard tcezard Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change have been introduce by ragel transpiler

Copy link
Contributor

@apriltuesday apriltuesday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to plead ignorance on the size_t to long unsigned int change... but otherwise this looks fine.

src/vcf/vcf_v42.ragel Outdated Show resolved Hide resolved
@tcezard tcezard merged commit 76b0d2b into EBIvariation:master Jul 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants