Pivotal ID # 185645993: Kotlin AWS S3 Client #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -208,4 +211,8 @@ private class PmcLoader( | |||
| bioStudiesUrl = properties.bioStudiesUrl, | |||
| submissionId = submissionId, | |||
| ) | |||
|
|
|||
| private companion object { | |||
| const val JOB_MINUTES = 48 * 60 | |||
There was a problem hiding this comment.
Why 48 minutes? Maybe we should add documentation to explain this
x.txt
Outdated
| @@ -0,0 +1,7004 @@ | |||
| Starting a Gradle Daemon, 1 busy and 1 incompatible and 1 stopped Daemons could not be reused, use --status for details | |||
There was a problem hiding this comment.
It looks like this file was commited by mistake?
| import uk.ac.ebi.fire.client.integration.web.FireS3Client | ||
| import java.io.File | ||
| import java.nio.file.Files | ||
| import java.nio.file.StandardCopyOption | ||
|
|
||
| class S3Client( | ||
| class S3JClient( |
There was a problem hiding this comment.
Are you considering adding a feature flag in another PR to choose between one client or the other? Otherwise, we could delete this class since, after this change, it will only be used by tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/185645993