Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 188035630: Request Status CLI Operation #872

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

jhoanmanuelms
Copy link
Contributor

https://www.pivotaltracker.com/story/show/188035630

  • Create command to get a request status
  • Fix operation method in the web client
  • Handle scenario for request not found

- Create command to get a request status
- Fix operation method in the web client
- Handle scenario for request not found
@jhoanmanuelms jhoanmanuelms self-assigned this Aug 23, 2024
@jhoanmanuelms jhoanmanuelms requested a review from Juan-EBI August 23, 2024 15:33
Copy link
Contributor

@Juan-EBI Juan-EBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -16,7 +16,7 @@ class SubmissionRequestClient(
version: Int,
): RequestStatus =
client
.post()
.get()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need an itest for this one. I had created https://www.pivotaltracker.com/story/show/188165943

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added the itest as part of this ticket 👍

@jhoanmanuelms jhoanmanuelms merged commit 4dad399 into master Aug 28, 2024
1 check passed
@jhoanmanuelms jhoanmanuelms deleted the feature/pivotal-#188035630-cli-request-status branch August 28, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants