Pivotal ID # 188131969: Archieve submission request #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
approved these changes
Aug 19, 2024
| ) { | ||
| client | ||
| .post() | ||
| .uri("$SUBMISSION_REQUEST_URL/$accNo/$version/archieve") |
There was a problem hiding this comment.
Typo: archive (the same typo is present in the ticket name)
| @@ -1,6 +1,6 @@ | |||
| package ebi.ac.uk.db | |||
|
|
|||
| const val MONGO_VERSION = "mongo:4.0.10" | |||
| const val MONGO_VERSION = "mongo:4.4.22" | |||
| @@ -127,6 +127,11 @@ interface SubmissionRequestPersistenceService { | |||
| accNo: String, | |||
| version: Int, | |||
| ): Boolean | |||
|
|
|||
| suspend fun archieveRequest( | |||
| val created = result.matchedCount < 1 | ||
| return submissionRequestRepository.getByAccNoAndStatusIn(request.accNo, PROCESSING) to created | ||
| } | ||
|
|
||
| suspend fun archieveRequest( |
| @@ -49,6 +49,22 @@ class SubmissionRequestMongoPersistenceService( | |||
| return request.map { it.accNo to it.version } | |||
| } | |||
|
|
|||
| override suspend fun archieveRequest( | |||
| ) { | ||
| @AfterEach | ||
| fun afterEach() = | ||
| runBlocking { | ||
| testInstance.deleteAll() | ||
| } | ||
|
|
||
| @Test | ||
| fun archieveRequest() = |
|
|
||
| val archievedFiles = | ||
| archieveRequestFiles() | ||
| .every(REPORT_RATE) { "$accNo, $version archieved file ${it.index}, path='${it.value.path}'" } |
| filesRepository.save(rqtF2) | ||
| testInstance.saveRequest(request) | ||
|
|
||
| val result = testInstance.archieveRequest("abc-123", 2) |
There was a problem hiding this comment.
The test should also include validations for the request no longer being present in the requests collection
| ) { | ||
| require( | ||
| requestRepository.existsByAccNoAndVersionAndStatus(accNo, version, PROCESSED), | ||
| ) { "Request $accNo, $version can not be archieved as not processed" } |
There was a problem hiding this comment.
suggestion: "Request $accNo, $version can't be archived since it's not processed"
| accNo: String, | ||
| version: Int, | ||
| ) { | ||
| requestPersistenceService.archieveRequest(accNo, version) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/188131969