Pivotal ID # 188114384: Scheduler SLURM Migration #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create common Cluster config class - Add option to execute scheduler jobs in SLURM - Remove unused code
Juan-EBI
approved these changes
Aug 15, 2024
| @@ -90,7 +90,6 @@ class LsfClusterClient( | |||
| companion object { | |||
| const val DONE_STATUS = "DONE" | |||
| const val EXIT_STATUS = "EXIT" | |||
| const val PEND_STATUS = "PEND" | |||
There was a problem hiding this comment.
why we have remove this one? (I remember seeing as a valid state)
There was a problem hiding this comment.
It was never used. Maybe we need to do something with it
There was a problem hiding this comment.
yes is not used in a particular test but it is used when obtained job status using API
Fix broken import
Fix jobs properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/188114384