Pivotal ID # 185361632: Avoid Files Modification On Public Studies #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create a new stage to validate file changes - Add new permission to allow file modifications on public studies - Mark the submission as invalid in case the file validation fails - Add integration tests
Juan-EBI
reviewed
Jul 15, 2024
...ore/src/main/kotlin/ac/uk/ebi/biostd/submission/domain/request/SubmissionRequestValidator.kt
Outdated
Show resolved
Hide resolved
...ore/src/main/kotlin/ac/uk/ebi/biostd/submission/domain/request/SubmissionRequestValidator.kt
Outdated
Show resolved
Hide resolved
...ore/src/main/kotlin/ac/uk/ebi/biostd/submission/domain/request/SubmissionRequestValidator.kt
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| fun `5-8 authorized user updates public submission files`() = |
There was a problem hiding this comment.
I think we need 3 more scenarios.
- Allow pagetab files to be modified (without specific permisions).
- Allow file list metadata to be modified (without specific permisions).
- File list files can not be modified
There was a problem hiding this comment.
Number 1 is already there
Number 2 was added to the latest commit
Number 3 was added to an existing test case
I also added a new test to avoid removing the file list altogether
There was a problem hiding this comment.
maybe we shoud use @nested as all this cases are related to the same scenario.
...ore/src/main/kotlin/ac/uk/ebi/biostd/submission/domain/request/SubmissionRequestValidator.kt
Show resolved
Hide resolved
- Detect changes in pagetab files and keep count - Fix the logic used to detect changes in the submission files - Improve integration tests - Improve code readability - Remove unused code
Juan-EBI
approved these changes
Jul 18, 2024
| @@ -5,6 +5,7 @@ enum class AccessType { | |||
| ATTACH, | |||
| UPDATE, | |||
| DELETE, | |||
| UPDATE_PUBLIC, | |||
There was a problem hiding this comment.
in the future I think we may split this change in two tickets:
- Prevent non page tab files to be deleted
- Allow delete files annotation.
...ore/src/main/kotlin/ac/uk/ebi/biostd/submission/domain/request/SubmissionRequestValidator.kt
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| fun `5-8 authorized user updates public submission files`() = |
There was a problem hiding this comment.
maybe we shoud use @nested as all this cases are related to the same scenario.
- Improved testing - Updated FTP dependency
Remove unnecessary unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/185361632