Pivotal ID # 187734050: CLI Submit Timeout #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resource to get a request status - Move the RequestStatus to the core model - Add a new parameter to specify the timeout on submit - Add missing deployment stage - Fix CLI docs - Remove unnecessary properties from the config files
Juan-EBI
approved these changes
Jun 13, 2024
...nt/bio-commandline/src/main/kotlin/uk/ac/ebi/biostd/client/cli/services/SubmissionService.kt
Show resolved
Hide resolved
| val client = bioWebClient(rqt.securityConfig) | ||
| return client.submitSingle(rqt.submissionFile, rqt.filesConfig).body | ||
| val client = bioWebClient(request.securityConfig) | ||
| val acceptedSubmission = client.asyncSubmitSingle(request.submissionFile, request.filesConfig) |
There was a problem hiding this comment.
val (accNo, version) = client.asyncSubmitSingle(request.submissionFile, request.filesConfig)
client/bio-commandline/src/main/kotlin/uk/ac/ebi/biostd/client/cli/commands/SubmitCommand.kt
Outdated
Show resolved
Hide resolved
...ebapp/src/main/kotlin/ac/uk/ebi/biostd/submission/web/resources/SubmissionRequestResource.kt
Show resolved
Hide resolved
Juan-EBI
reviewed
Jun 13, 2024
- New wait operation that waits indefinitely - Add flag to wait indefinitely - Update imports
- Fix typo - Remove unnecessary annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/187734050