Pivotal ID # 187484499: Make Files Private On Resubmission #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the un-publish fire operation to return the un-published file - Make files private when a submission becomes private
Juan-EBI
reviewed
Jun 13, 2024
...ence-filesystem/src/main/kotlin/ac/uk/ebi/biostd/persistence/filesystem/nfs/NfsFtpService.kt
Outdated
Show resolved
Hide resolved
...ence-filesystem/src/main/kotlin/ac/uk/ebi/biostd/persistence/filesystem/nfs/NfsFtpService.kt
Outdated
Show resolved
Hide resolved
...core/src/main/kotlin/ac/uk/ebi/biostd/submission/domain/request/SubmissionRequestReleaser.kt
Outdated
Show resolved
Hide resolved
...core/src/main/kotlin/ac/uk/ebi/biostd/submission/domain/request/SubmissionRequestReleaser.kt
Show resolved
Hide resolved
...core/src/main/kotlin/ac/uk/ebi/biostd/submission/domain/request/SubmissionRequestReleaser.kt
Outdated
Show resolved
Hide resolved
...core/src/main/kotlin/ac/uk/ebi/biostd/submission/domain/request/SubmissionRequestReleaser.kt
Outdated
Show resolved
Hide resolved
Code review comments
Juan-EBI
approved these changes
Jun 24, 2024
client/fire-webclient/src/main/kotlin/uk/ac/ebi/fire/client/api/FireWebClient.kt
Outdated
Show resolved
Hide resolved
...filesystem/src/main/kotlin/ac/uk/ebi/biostd/persistence/filesystem/api/FileStorageService.kt
Outdated
Show resolved
Hide resolved
...ence-filesystem/src/main/kotlin/ac/uk/ebi/biostd/persistence/filesystem/nfs/NfsFtpService.kt
Show resolved
Hide resolved
...ence-filesystem/src/main/kotlin/ac/uk/ebi/biostd/persistence/filesystem/nfs/NfsFtpService.kt
Outdated
Show resolved
Hide resolved
...filesystem/src/main/kotlin/ac/uk/ebi/biostd/persistence/filesystem/service/StorageService.kt
Outdated
Show resolved
Hide resolved
...-filesystem/src/test/kotlin/ac/uk/ebi/biostd/persistence/filesystem/nfs/NfsFtpServiceTest.kt
Outdated
Show resolved
Hide resolved
...-filesystem/src/test/kotlin/ac/uk/ebi/biostd/persistence/filesystem/nfs/NfsFtpServiceTest.kt
Show resolved
Hide resolved
| @@ -63,6 +64,7 @@ class SubmissionRequestCleanIndexer( | |||
| newFiles: FilesRecords, | |||
| current: ExtSubmission, | |||
| ): Triple<Int, Int, Int> { | |||
| val reusedIdx = AtomicInteger(0) | |||
There was a problem hiding this comment.
if you noticed we return conflict and deprecated values so latter we know what is the amount of files to delete so we can acurrectly calculate the progress of procress. With reused files we are not so when we are actually unreleased we do not know how many files are pending.
Not saying this need to be included in this ticket which was already a huge effort but I think having precise estimation of pending activities is something we do not want to lose. Create a ticket to address that after this?
There was a problem hiding this comment.
nice catch, I added the changes 👍
...webapp/src/itest/kotlin/ac/uk/ebi/biostd/itest/test/submission/submit/ResubmissionApiTest.kt
Show resolved
Hide resolved
...webapp/src/itest/kotlin/ac/uk/ebi/biostd/itest/test/submission/submit/ResubmissionApiTest.kt
Outdated
Show resolved
Hide resolved
- Use native web client commands - Improve tests readability
Persist reused files count
jhoanmanuelms
deleted the
bugfix/pivotal-#187484499-make-files-private-on-suppress-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/187484499