-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pivotal ID # 187690245: Simplify Deployment Task #841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great changes, much more manageable 👍
Please check my comments
- gradle updatePmcArtifact -Penv=codon -PdeployPath=$CODON_APPS_PATH/scheduler/prod/apps | ||
- gradle deployScheduler -Penv=prod -PdeployPath=$APPS_PATH/scheduler/prod | ||
- gradle updateStatsReporterArtifact -Penv=codon -PdeployPath=$CODON_APPS_PATH/scheduler/prod/apps | ||
- gradle deployHandlers -Penv=prod -PdeployPath=$APPS_PATH/handlers/prod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing sandbox deployment
gradle deployHandlers -Penv=sandbox -PdeployPath=$APPS_PATH/handlers/sandbox
- gradle deployHandlers -Penv=prod -PdeployPath=$APPS_PATH/handlers/prod | ||
- gradle updateMigratorArtifact -Penv=codon -PdeployPath=$CODON_APPS_PATH/scheduler/prod/apps | ||
- gradle updateReleaserArtifact -Penv=codon -PdeployPath=$CODON_APPS_PATH/scheduler/prod/apps | ||
- gradle updateSubmissionTaskArtifact -Penv=prod -PdeployPath=$APPS_PATH/submitter/prod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized we were missing the task deployment for the sandbox environment. We should add it here
Include Sandbox deployment
https://www.pivotaltracker.com/story/show/187690245