Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 187690245: Simplify Deployment Task #841

Merged
merged 10 commits into from
May 29, 2024

Conversation

Juan-EBI
Copy link
Contributor

@Juan-EBI Juan-EBI requested a review from jhoanmanuelms May 29, 2024 06:25
Copy link
Contributor

@jhoanmanuelms jhoanmanuelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great changes, much more manageable 👍

Please check my comments

- gradle updatePmcArtifact -Penv=codon -PdeployPath=$CODON_APPS_PATH/scheduler/prod/apps
- gradle deployScheduler -Penv=prod -PdeployPath=$APPS_PATH/scheduler/prod
- gradle updateStatsReporterArtifact -Penv=codon -PdeployPath=$CODON_APPS_PATH/scheduler/prod/apps
- gradle deployHandlers -Penv=prod -PdeployPath=$APPS_PATH/handlers/prod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing sandbox deployment

gradle deployHandlers -Penv=sandbox -PdeployPath=$APPS_PATH/handlers/sandbox

- gradle deployHandlers -Penv=prod -PdeployPath=$APPS_PATH/handlers/prod
- gradle updateMigratorArtifact -Penv=codon -PdeployPath=$CODON_APPS_PATH/scheduler/prod/apps
- gradle updateReleaserArtifact -Penv=codon -PdeployPath=$CODON_APPS_PATH/scheduler/prod/apps
- gradle updateSubmissionTaskArtifact -Penv=prod -PdeployPath=$APPS_PATH/submitter/prod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized we were missing the task deployment for the sandbox environment. We should add it here

@jhoanmanuelms jhoanmanuelms changed the title Pivotal ID # 187690245: Simplify deployment task Pivotal ID # 187690245: Simplify Deployment Task May 29, 2024
@jhoanmanuelms jhoanmanuelms merged commit 08df1f4 into master May 29, 2024
1 check passed
@jhoanmanuelms jhoanmanuelms deleted the feature/pivotal-187690245 branch May 29, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants