Pivotal ID # 187133668: DOI Last Name #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register the DOI without contributors when the authors name is not complete
Juan-EBI
approved these changes
May 3, 2024
| private fun getContributors(submission: Submission): List<Contributor> { | ||
| fun isNameValid(author: Section): Boolean { | ||
| val name = author.findAttr(NAME_ATTR) | ||
| return name.isNotBlank() && name!!.contains(" ") |
There was a problem hiding this comment.
white spaes are part of blank definition so I think that is not neded.
public actual fun CharSequence.isBlank(): Boolean = length == 0 || indices.all { this[it].isWhitespace() }
| val contributors = | ||
| submission | ||
| .allSections() | ||
| .filter { it.type.lowercase() == AUTHOR_TYPE.lowercase() } |
There was a problem hiding this comment.
what about it.type.equals(AUTHOR_TYPE, ignoreCase = true)
Code review comments
Fix CLI deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register the DOI without contributors when the authors name is not complete