Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 186859974: Switch URl on basis of user upload mode #831

Merged
merged 5 commits into from
May 30, 2024

Conversation

Juan-EBI
Copy link
Contributor

@Juan-EBI Juan-EBI requested a review from jhoanmanuelms April 30, 2024 13:42
Copy link
Contributor

@jhoanmanuelms jhoanmanuelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor comment

@@ -74,6 +79,28 @@ class SecurityApiTest(
assertThat(user.email).isEqualTo("case-insensitive-inactive@mail.org")
}

@Test
fun `22-6 check ftp home type user`() =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests should be added to the inventory

@Juan-EBI Juan-EBI merged commit 5951019 into master May 30, 2024
1 check passed
@Juan-EBI Juan-EBI deleted the feature/pivotal-186859974 branch August 7, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants