Pivotal ID # 187456681: Submission request file status #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juan-EBI
commented
Apr 18, 2024
| * Update the given request files. By default only file index is updated in submission request. For other options | ||
| * @see UpdateOptions | ||
| */ | ||
| suspend fun updateRqtFile( |
There was a problem hiding this comment.
this change will allow to change file status in future set of changes without chaning API
Juan-EBI
commented
Apr 18, 2024
| @@ -56,7 +56,7 @@ internal class DistributedLockExecutor( | |||
| ) | |||
|
|
|||
| private companion object { | |||
| val DEFAULT_EXPIRATION = Duration.ofMinutes(5) | |||
| val DEFAULT_EXPIRATION = Duration.ofHours(3) | |||
There was a problem hiding this comment.
extended lock time to avoid two submission being processed concurrently after lock expire (we need refresh lock feature)
jhoanmanuelms
approved these changes
Apr 18, 2024
| requestFile: SubmissionRequestFile, | ||
| file: ExtFile, | ||
| /** | ||
| * Update the given request files. By default only file index is updated in submission request. For other options |
There was a problem hiding this comment.
Typo: It should be file, singular. The docs imply several files could be passed to the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/187456681