Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 187009218: Improve CLI Async Submit Feedback #807

Merged

Conversation

jhoanmanuelms
Copy link
Contributor

https://www.pivotaltracker.com/story/show/187009218

  • Provide information about the accNo / version once the async submission is accepted
  • Provide a new endpoint that allows querying by accNo / version
  • Add a deprecation warning for the submit command

- Provide information about the accNo / version once the async submission is accepted
- Provide a new endpoint that allows querying by accNo / version
- Add a deprecation warning for the submit command
@jhoanmanuelms jhoanmanuelms self-assigned this Feb 21, 2024
Copy link
Contributor

@Juan-EBI Juan-EBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please consider minor changes

- Improve response class naming
- Improve exception to include version
- Add tests
@jhoanmanuelms jhoanmanuelms marked this pull request as ready for review March 1, 2024 21:39
@jhoanmanuelms jhoanmanuelms merged commit de05793 into master Mar 14, 2024
1 check passed
@jhoanmanuelms jhoanmanuelms deleted the bugfix/pivotal-#187009218-async-submit-enhancement branch March 14, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants