Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 186768872: Input FTP Folder Permission Structure Review #801

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

jhoanmanuelms
Copy link
Contributor

https://www.pivotaltracker.com/story/show/186768872

  • Add a property for the ftp root path
  • Simplify FTP source logic
  • Remove unused code
  • Fix typos

- Add a property for the ftp root path
- Simplify FTP source logic
- Remove unused code
- Fix typos
@jhoanmanuelms jhoanmanuelms self-assigned this Jan 26, 2024
Copy link
Contributor

@Juan-EBI Juan-EBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Set FTP root path upon client creation
- Fix warnings and typos
@jhoanmanuelms jhoanmanuelms merged commit f94d750 into master Jan 30, 2024
1 check passed
@jhoanmanuelms jhoanmanuelms deleted the chore/pivotal-#186768872-ftp-root-path branch January 30, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants