Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 186547510: Configurable Notifications E-Mail Subject #800

Conversation

jhoanmanuelms
Copy link
Contributor

https://www.pivotaltracker.com/story/show/186547510

  • Use the configuration mechanism to set the e-mail subject
  • Use constructor binding for the handlers app configuration in order to avoid missing properties
  • Remove unused properties
  • Improve tests

- Use the configuration mechanism to set the e-mail subject
- Use constructor binding for the handlers app configuration in order to avoid missing properties
- Remove unused properties
- Improve tests
@jhoanmanuelms jhoanmanuelms self-assigned this Jan 24, 2024
Copy link
Contributor

@Juan-EBI Juan-EBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhoanmanuelms jhoanmanuelms merged commit 26c8a99 into master Jan 30, 2024
1 check passed
@jhoanmanuelms jhoanmanuelms deleted the feature/pivotal-#186547510-configurable-notification-ubject branch January 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants