Pivotal ID # 186609885: Access cluster logs admin API #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
approved these changes
Jan 12, 2024
| @@ -34,6 +37,10 @@ class LocalClusterClient : ClusterClient { | |||
| return if (process.isAlive) "RUNNING" else "DONE" | |||
| } | |||
|
|
|||
| override suspend fun jobLogs(jobId: String): String { | |||
| return jobLogs.getValue(jobId.toLong()).readText() | |||
There was a problem hiding this comment.
I'm just curious, why do you use getValue instead of jobLogs[jobId.toLong()] ?
There was a problem hiding this comment.
nullable vs not nullable
| @@ -49,6 +49,13 @@ class RemoteClusterClient( | |||
| } | |||
| } | |||
|
|
|||
| override suspend fun jobLogs(jobId: String): String { | |||
| return runInSession { | |||
| val (_, response) = executeCommand("cat $logsPath/${jobId}_OUT") | |||
There was a problem hiding this comment.
And there we were, thinking about datamovers and separate jobs 🤣
Well done man 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/186609885