Pivotal ID # 186657310: Task Completion Publish Message #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Delegate sending the completion message to the task itself - Convert the call to the submission task into an async triggering - Sync submit waits for the async execution to finish since it's intended for small submissions
Remove unnecessary code
Fix sync submission
Integration and unit tests
Juan-EBI
approved these changes
Jan 15, 2024
| eventsPublisherService.requestCreated(accNo, version) | ||
| waitUntil(duration = ofMinutes(SYNC_SUBMIT_TIMEOUT)) { queryService.existByAccNoAndVersion(accNo, version) } | ||
|
|
||
| return queryService.getExtByAccNo(accNo) |
There was a problem hiding this comment.
I will suggest we create the function
suspend fun <T> waitUntil(
duration: Duration,
interval: Duration = Duration.ofMillis(300),
conditionEvaluator: suspend () -> Boolean,
processFunction: suspend () -> T,
): T {
waitUntil(duration, interval, conditionEvaluator)
return processFunction()
}
and then here
return waitUntil(
ofMinutes(SYNC_SUBMIT_TIMEOUT),
conditionEvaluator = { queryService.existByAccNoAndVersion(accNo, version) },
processFunction = { queryService.getExtByAccNoAndVersion(accNo, version) })
wait and having a return type looks like a coomon need .
- Create typed async function - Fix typo
jhoanmanuelms
deleted the
feature/pivotal-#186657310-submission-stages-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/186657310