Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 186232047: Manager Should Not Be Able To Delete #795

Merged

Conversation

jhoanmanuelms
Copy link
Contributor

https://www.pivotaltracker.com/story/show/186232047

  • Separate admin from regular permissions
  • Allow deletion only for specific permission or author of private submission
  • Improve integration testing
  • Add unit testing

- Separate admin from regular permissions
- Allow deletion only for specific permission or author of private submission
- Improve integration testing
- Add unit testing
@jhoanmanuelms jhoanmanuelms self-assigned this Dec 21, 2023
Copy link
Contributor

@Juan-EBI Juan-EBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhoanmanuelms jhoanmanuelms merged commit abc225b into master Jan 9, 2024
1 check passed
@jhoanmanuelms jhoanmanuelms deleted the feature/pivotal-#186232047-manager-not-delete branch January 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants