Pivotal ID # 186657295: Retrigger Submission Task #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle re-triggering for submissions executed remotely - Remove unused code
Juan-EBI
approved these changes
Dec 18, 2023
| suspend fun cleanRequest(accNo: String, version: Int): Unit | ||
| suspend fun processRequest(accNo: String, version: Int): Unit | ||
| suspend fun checkReleased(accNo: String, version: Int): Unit | ||
| suspend fun indexRequest(accNo: String, version: Int) |
There was a problem hiding this comment.
i start adding explicit return type only to public api/functions as for example if you call a method in the last line of function body the return value becomes something and may break unit test for example.
jhoanmanuelms
deleted the
feature/pivotal-#186657295-retrigger-dm-submissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/186657295