Pivotal ID #186675047: FTP connection pool #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
approved these changes
Dec 14, 2023
|
|
||
| /** | ||
| * Pooled FTP client. Allows to re use FTPClient instances so socket connections and ftp logging does not need to be | ||
| * perform on each FTP operation. |
There was a problem hiding this comment.
typo: ... does not need to be performed on each ...
| return try { | ||
| ftpClient.sendNoOp() | ||
| } catch (e: Exception) { | ||
| logger.error(e) { "Error checking ftp connection" } |
There was a problem hiding this comment.
I think we should log the exception message
There was a problem hiding this comment.
logger.error(e) will garantee is logged
| ): GenericObjectPool<FTPClient> { | ||
| val factory = FTPClientFactory(ftpUser, ftpPassword, ftpUrl, ftpPort) | ||
| var connections = GenericObjectPool(factory) | ||
| connections.minIdle = 2 |
There was a problem hiding this comment.
Doesn't this throw magic number warning?
| } | ||
|
|
||
| /** | ||
| * As Ftp clients are re used we need to garantee that if working directory is changed it is restored after |
There was a problem hiding this comment.
edit suggestion: ... to guarantee that, if the working directory is changed, it is restored after the operation is completed.
| private val testInstance = FtpClient.create(FTP_USER, FTP_PASSWORD, ftpServer.getUrl(), ftpServer.ftpPort) | ||
|
|
||
| @Test | ||
| fun `upload a file, list and download it`() { |
There was a problem hiding this comment.
I'd suggest: upload a file, list it and download it because for a moment I thought the comma was not intentional and it was referring to a file list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/186675047