Pivotal ID #186578721: Allow to execute test jobs in cluster API #781
Conversation
| @@ -25,6 +25,8 @@ class ClusterOperations( | |||
| private val sessionFunction: () -> Session, | |||
| ) { | |||
| suspend fun triggerJob(jobSpec: JobSpec): Try<Job> { | |||
| logger.info { "Triggering Job $jobSpec" } | |||
| } | ||
| } | ||
|
|
||
| suspend fun runJob( |
There was a problem hiding this comment.
After looking at this improvement, I think we should probably call these methods triggerJobAsync and triggerJobSync just to make it super clear the difference between them. Another option would be adding Javadoc. WDYT?
| @@ -0,0 +1,39 @@ | |||
| -----BEGIN RSA PRIVATE KEY----- | |||
There was a problem hiding this comment.
I don't think it's a good idea to persist private keys in the repo
There was a problem hiding this comment.
is a dummy key required for itest to run
| return clusterOperations.jobStatus(jobId) | ||
| } | ||
|
|
||
| data class JobSpecDto(val command: String, val queue: String, val megaBytes: Int) { |
There was a problem hiding this comment.
I think the last parameter should be called memory, ramSize or even just ram like in the Job class because megaBytes is not very clear at communicating what the value is actually used for
| } | ||
|
|
||
| @PostMapping("/submit") | ||
| suspend fun submitJob(@RequestBody job: JobSpecDto): Job { |
There was a problem hiding this comment.
I think these endpoints will be super useful
https://www.pivotaltracker.com/story/show/186578721