Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 186485559: Submission task tracing #780

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

Juan-EBI
Copy link
Contributor

Copy link
Contributor

@jhoanmanuelms jhoanmanuelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


override suspend fun getPersistedRequest(accNo: String, version: Int, processId: String): SubmissionRqt {
return getRequest(accNo, version, PERSISTED, processId)
override suspend fun getRqt(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call it getSubmissionRequest just to make clear which type of request it's

@Juan-EBI Juan-EBI merged commit 547643d into master Nov 30, 2023
@Juan-EBI Juan-EBI deleted the feature/pivotal-186485559 branch January 11, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants