Pivotal ID # 186293173: Persist Files With Duplicated MD5 And Different Name #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt Name - Remove MD5 search - Check for the appropriate web client error when using the find by path endpoint - Use the actual data returned by fire when storing it to the database - Use a mutex to avoid race conditions - Add an integration test
…nt Name Fix inventory file indentation
Juan-EBI
reviewed
Oct 29, 2023
...-filesystem/src/main/kotlin/ac/uk/ebi/biostd/persistence/filesystem/fire/FireFilesService.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/ac/uk/ebi/biostd/submission/submitter/request/SubmissionRequestProcessor.kt
Outdated
Show resolved
Hide resolved
...p/src/itest/kotlin/ac/uk/ebi/biostd/itest/test/submission/submit/SubmissionFileSourceTest.kt
Show resolved
Hide resolved
...p/src/itest/kotlin/ac/uk/ebi/biostd/itest/test/submission/submit/SubmissionFileSourceTest.kt
Outdated
Show resolved
Hide resolved
…nt Name - Improve file finding condition - Improve tests
…nt Name Remove sync version of the find by md5 operation
Juan-EBI
reviewed
Oct 31, 2023
...-filesystem/src/main/kotlin/ac/uk/ebi/biostd/persistence/filesystem/fire/FireFilesService.kt
Outdated
Show resolved
Hide resolved
...-filesystem/src/main/kotlin/ac/uk/ebi/biostd/persistence/filesystem/fire/FireFilesService.kt
Outdated
Show resolved
Hide resolved
…nt Name - Remove md5 search functionality - Remove fire file source - Make the fire path NOT nullable for FireFile - Remove unnecessary tests
…nt Name Remove unused import
jhoanmanuelms
deleted the
bugfix/pivotal-#186293173-same-md5-different-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/186293173