Pivotal ID # 186322997: S-BIAD877 could not be loaded #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juan-EBI
commented
Oct 25, 2023
| fun deserializeSubmission(file: File): Submission | ||
|
|
||
| suspend fun deserializeSubmission(file: File, source: FileSourcesList): Submission | ||
| @Blocking |
There was a problem hiding this comment.
@jhoanmanuelms lets start using this one so we know when a code is blocking
jhoanmanuelms
approved these changes
Oct 26, 2023
| files | ||
| .collect { file -> | ||
| count.getAndIncrement() | ||
| logger.info { "writting file ${count.get()}" } |
There was a problem hiding this comment.
I think this message might be confusing since it's only displaying a number and we might have several concurrent files, perhaps we should include more info such as the file name
| val file = Files.createTempFile("file-list", "${files.size}-files") | ||
| val serializer = SerializationConfig.serializationService() | ||
| file.outputStream().use { serializer.serializeFileList(files.asSequence(), format, it) } | ||
| return file.toFile() | ||
| file.outputStream().use { serializer.serializeFileList(files.asFlow(), format, it) } |
There was a problem hiding this comment.
Shouldn't this also be executed in the IO context?
There was a problem hiding this comment.
yes but it will require the function to be suspended and we use it as a top level. So because it is a test I think runBlocking will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/186322997