Pivotal ID # 185900074: Accept Requests With Large Directories Times Out #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid directories calculation at the moment of generating pagetab
Juan-EBI
reviewed
Nov 3, 2023
| @@ -8,9 +8,11 @@ import ebi.ac.uk.model.BioFile | |||
|
|
|||
| internal const val TO_FILE_EXTENSIONS = "ebi.ac.uk.extended.mapping.to.ToFileKt" | |||
|
|
|||
| fun ExtFile.toFile(): BioFile { | |||
| fun ExtFile.toFile(calculateDirectories: Boolean = true): BioFile { | |||
There was a problem hiding this comment.
is confusing for me when the files size need to be calculated and when not. Like all operations support both calculating them and not calculating. How is posible that calculating them is some parts is good but in others not? I think code does not reveal when is necesary to calculated and when is not
Juan-EBI
approved these changes
Nov 6, 2023
Avoid calculating the size for inner directories by default
jhoanmanuelms
deleted the
bugfix/pivotal-#185900074-avoid-directories-calculation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/185900074
Avoid directories calculation at the moment of generating pagetab