Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pivotal ID # 185788503: Reactive Mongo #754

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Pivotal ID # 185788503: Reactive Mongo #754

merged 2 commits into from
Oct 2, 2023

Conversation

Juan-EBI
Copy link
Contributor

@Juan-EBI Juan-EBI commented Oct 1, 2023

  • removed flux references

jhoanmanuelms
jhoanmanuelms approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@jhoanmanuelms jhoanmanuelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice changes to avoid all these conversions 👍. LGTM, please consider my comment

...go/src/main/kotlin/ac/uk/ebi/biostd/persistence/doc/db/reactive/repositories/Repositories.kt

suspend fun getByPathAndAccNoAndVersion(path: String, accNo: String, version: Int): DocSubmissionRequestFile
}

interface FileListDocFileRepository : CoroutineCrudRepository<FileListDocFile, ObjectId> {
@Meta(cursorBatchSize = 100, flags = [org.springframework.data.mongodb.core.query.Meta.CursorOption.NO_TIMEOUT])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this was added in order to avoid the cursor timeout issue when processing large file lists. I don't think we should remove it unless it doesn't have any effect when using the reactive client

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not using long query now but paged query so this is not necesary. That was the intention of this changes to remove long running cursor that may fail.

@Juan-EBI Juan-EBI merged commit 984a157 into master Oct 2, 2023
@Juan-EBI Juan-EBI deleted the feature/pivotal-185788503 branch November 21, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoanmanuelms jhoanmanuelms jhoanmanuelms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Juan-EBI @jhoanmanuelms