Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 186157290: Re execute test flaky itest #753

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

Juan-EBI
Copy link
Contributor

@Juan-EBI Juan-EBI commented Oct 1, 2023

Copy link
Contributor

@jhoanmanuelms jhoanmanuelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, LGTM. Please consider my comment

@@ -71,6 +72,7 @@ plugins {
id(Plugins.KotlinAllOpenPlugin) version PluginVersions.KotlinPluginVersion
id(Plugins.SpringBootPlugin) version PluginVersions.SpringBootPluginVersion
id(Plugins.SpringDependencyManagementPlugin) version PluginVersions.SpringDependencyManagementPluginVersion
id("org.gradle.test-retry") version "1.5.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to add it to the definitions file for easier maintenance

classDumpDir = file("$buildDir/jacoco/classpathdumps")
}

retry {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@Juan-EBI Juan-EBI merged commit a8eddbe into master Oct 2, 2023
@Juan-EBI Juan-EBI deleted the feature/pivotal-186157290 branch October 2, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants