Pivotal ID # 186152624: Search Folder with zip extension when Fire submission #752
Conversation
| @@ -1,146 +1,147 @@ | |||
| | Class | Test No | Test name | Description | | |||
| |---------------------------------|---------|-----------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------| | |||
There was a problem hiding this comment.
I think something went wrong with this file, why do we have so many changes? 🤔
There was a problem hiding this comment.
because my description column take longer than other so column have to be moved for everyrow
| @@ -67,3 +69,8 @@ fun String.scape(toScape: String, scapeLiteral: String = "\\"): String = replace | |||
| * Replaces multiple whitespaces with a single space. | |||
| */ | |||
| fun String.trim(): String = replace("\\s+".toRegex(), " ") | |||
|
|
|||
| /** | |||
| * Compute the given string so it always ends in the provided suffix, no action is taking if string already. | |||
There was a problem hiding this comment.
I'd suggest:
... provided suffix. No action will be taken if the string already finishes with the expected suffix.
|
|
||
| private fun expectedPath(path: String, type: String): String { | ||
| return when (sub.storageMode) { | ||
| StorageMode.FIRE -> if (type == FileFields.DIRECTORY_TYPE.value) path.ensureSuffix(".zip") else path |
There was a problem hiding this comment.
I think we should leave a TODO here to remove this code once all the submissions have been migrated to FIRE since this looks like a data issue more than a code bug. WDYT?
There was a problem hiding this comment.
actually this will remanins IMO as we will always save file in pagetab as directory but in DB it will be always directory.zip unless we stop supporting this feature but not related with Fire migration.
…services into feature/pivotal-186152624
https://www.pivotaltracker.com/story/show/186152624