Pivotal ID # 185352396: Fixed Concurrency File Operations #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make submit operations fully suspended - Improve some tests structure
Juan-EBI
approved these changes
Sep 1, 2023
| private fun processSafely(request: RequestMessage, process: RequestMessage.() -> Unit) { | ||
| runCatching { process(request) }.onFailure { onError(it, request) } | ||
| private fun processSafely(request: RequestMessage, process: suspend RequestMessage.() -> Unit) { | ||
| runCatching { runBlocking { process(request) } }.onFailure { onError(it, request) } |
There was a problem hiding this comment.
I wondering if this is working correctly I mean if in error we get the exception of real problem of the issue or if it get wrapper in a CorotuineException or something like that that and we need to use the cause of the exception and no the exception itself. Did you check this?
There was a problem hiding this comment.
You're right, it should be the other way around: runCatching inside runBlocking. Nice catch 😁👍
| every { extSerializationService.deserialize(submissionJson) } returns extSubmission | ||
|
|
||
| mvc.multipart("/submissions/extended") { | ||
| content = submissionJson | ||
| param(SUBMISSION, submissionJson) | ||
| }.andExpect { | ||
| }.asyncDispatch().andExpect { |
There was a problem hiding this comment.
is this needed? what does it do?
There was a problem hiding this comment.
Since now the endpoint is async, we need this to properly call the mock mvc object
- Fully suspended endpoints - Use supervisor scope instead of default dispatchers - Remove spring async timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/185352396