Pivotal ID # 185392832: Submission FTP files source #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juan-EBI
commented
Aug 13, 2023
| this.sources.clear() | ||
| return this.apply { builderAction() }.build() | ||
| } | ||
| fun buildFilesSourceList(builderAction: FilesSourceListBuilder.() -> Unit): FileSourcesList { |
There was a problem hiding this comment.
refactor to favor encapsulation.
Juan-EBI
commented
Aug 14, 2023
| @@ -15,7 +15,7 @@ class RegisterRequest( | |||
| var path: String? = null, | |||
| var orcid: String? = null, | |||
| val notificationsEnabled: Boolean = false, | |||
| val userFolderType: String? = null, | |||
| val storageMode: String? = null, | |||
There was a problem hiding this comment.
changed to be consistent with submission attribute
jhoanmanuelms
approved these changes
Aug 16, 2023
| return findFile(filePath)?.let { createFile(filePath, it, attributes) } | ||
| } | ||
|
|
||
| private fun findFile(filePath: String): File? { |
There was a problem hiding this comment.
As discussed, this could be changed in favor of a new implementation of ExtFile that wouldn't require an instance of File and would just contain the file's metadata
| else -> path | ||
| } | ||
|
|
||
| val filePath = if (type == DIRECTORY_TYPE.value) path.removeSuffix(".zip") else path |
| line() | ||
|
|
||
| line("Study") | ||
| line("File List", "FileList.tsv") |
There was a problem hiding this comment.
Since this test is specifically for FTP files, I would also include an inner submission file and not only file lists files, just to test all the branches of the code
…services into feature/pivotal-185392832-Submission-FTP-files-source
…services into feature/pivotal-185392832-Submission-FTP-files-source # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
jhoanmanuelms
deleted the
feature/pivotal-185392832-Submission-FTP-files-source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/185392832