Pivotal ID # 185786866: Simple automated performance test #739
Conversation
| line() | ||
|
|
||
| line("Files") | ||
| subFiles.forEach { line(it.name) } |
There was a problem hiding this comment.
The test looks awesome, I think this is worth measuring. I think it could benefit from adding the files through a file list rather than placing them directly in the submission just to add to the test case the overhead of reading the file list at each stage which is our most common case for big submissions.
Also, I think we could increase the number of files to 1000. It'll add an extra minute but the test will be closer to our actual use case.
WDYT?
There was a problem hiding this comment.
I think it is not a real performance test but rather a simple exercise to monitor performance in really really ideail conditions, I agree with using file list as this does help to test batch processing but 1000 files will be still an small number of files so I do not see much value there. We may think to use 1.000.000 but again this is not a real performance test so IMO it will not add much information than using 100 and will delay test execution.
There was a problem hiding this comment.
actually just test it with 1000 and runner JVM dies (and I think updating runner to match production machine and get "real performance" is out of the scope)
WDYT?
There was a problem hiding this comment.
yeah, maybe the execution is too long. I'd still like to see the files in a file list but I'll leave it to you.
There was a problem hiding this comment.
files are inded in a file list already
jhoanmanuelms
deleted the
feature/pivotal-185786866-Simple-automated-performance-test
branch
https://www.pivotaltracker.com/story/show/185786866