Pivotal ID # 185649200: Cater For Paths Ending With Backslash #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhoanmanuelms
commented
Aug 2, 2023
jhoanmanuelms
commented
- Create a common operation to get the file path since all of them should share the same logic
- Remove any trailing slash on file names
- Add integration tests for directories
- Update itests inventory
- Create a common operation to get the file path since all of them should share the same logic - Remove any trailing slash on file names - Add integration tests for directories - Update itests inventory
Juan-EBI
reviewed
Aug 11, 2023
commons/commons-serialization/src/main/kotlin/ac/uk/ebi/biostd/common/FileCommons.kt
Outdated
Show resolved
Hide resolved
- Avoid accepting submissions containing trailing slashes - Only validate the path at deserialization instead of changing the user's input - Use thread safe operation for directories creation (missed from last PR)
jhoanmanuelms
deleted the
bugfix/pivotal-#185649200-file-ending-with-backslash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.