Pivotal ID # 185460059: Retry E-Mails Only Once #734
Conversation
- Catch errors on security notifications - Use spring logs rolling back policy in order to compress the old log files
| ACTIVATION_BY_EMAIL -> securityNotificationService.sendActivationByEmailNotification(notification) | ||
| PASSWORD_RESET -> securityNotificationService.sendPasswordResetNotification(notification) | ||
| } | ||
| runCatching { |
There was a problem hiding this comment.
this is not retrying but rather sending a message when there is failure. Are this the expectaions? I guess we can at least retry a few times before screate the error message.
This approach looks interesting but maybe an overkill
There was a problem hiding this comment.
This is the expected approach. The idea of this ticket is to use the same mechanism that we use for the release notifications to register any failure (which we've historically had very few) in the notifications-failed-log queue instead of keeping retrying indefinitely.
This is actually a very similar approach to the one you suggested where the "parking lot" queue is the failed notifications log, we would just need to add automation to it. I've created a ticket for it.
There was a problem hiding this comment.
I was thinking that we were going to actually stop sending message there as no one actually monitor that queue but if this is the discussed approach that is ok.
jhoanmanuelms
deleted the
bugfix/pivotal-#185460059-process-notifications-safely
branch
https://www.pivotaltracker.com/story/show/185460059