Pivotal ID # 185110100: Case Insensitive Submission Ownership #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhoanmanuelms
commented
Jun 12, 2023
jhoanmanuelms
commented
- Ensure user email is always lowercase on registration
- Remove unnecessary data classes
- Ensure user email is always lowercase on registration - Remove unnecessary data classes
Juan-EBI
reviewed
Jun 13, 2023
|
|
||
| class EmailDeserializer : StdDeserializer<String>(String::class.java) { | ||
| override fun deserialize(p: JsonParser?, ctxt: DeserializationContext?): String { | ||
| return _parseString(p, ctxt).lowercase() |
There was a problem hiding this comment.
not sure about adding case insensitve check in web layer? should we add this servie layer directly? (so if we change how we call this, rule still in place)
Juan-EBI
reviewed
Jun 13, 2023
- Remove the validation at web layer - Change the email to lowercase at registration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.