Pivotal ID # 184724563: Use a specific user and server for the update script #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
requested changes
Jun 13, 2023
deploy.gradle
Outdated
| @@ -133,6 +133,8 @@ task deploy { | |||
| execute "sed -i -e 's~APP_PORT~$appPort~g' $deployPath/update.sh" | |||
| execute "sed -i -e 's~APP_NAME~$artifactName~g' $deployPath/update.sh" | |||
| execute "sed -i -e 's~DEBUG_PORT~$debugPort~g' $deployPath/update.sh" | |||
| execute "sed -i -e 's~BS_USER~`whoami`~g' $deployPath/update.sh" | |||
There was a problem hiding this comment.
Hi @awaisathar. I think we need to check the replacing command since it isn't actually replacing with the expected value in the script on the server.
You can test this by running this gradle command to deploy on dev:
./gradlew :submission:submission-webapp:bootJar deploySubmitter -Penv=dev -PdeployPath=$APPS_PATH/submitter/dev
The caveat is you'd need to export the required variables in your local console. Another way to test would be to push the changes to gitlab and test it from the deploy task there
There was a problem hiding this comment.
Should be fixed now.
There was a problem hiding this comment.
Works perfectly now. Thanks @awaisathar 😁👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.