Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pivotal ID # 185273996: Fire s3 path should be relative #714

Merged
merged 5 commits into from
May 30, 2023
Merged

Pivotal ID # 185273996: Fire s3 path should be relative #714

merged 5 commits into from
May 30, 2023

Conversation

Juan-EBI
Copy link
Contributor

@Juan-EBI Juan-EBI commented May 26, 2023 •
edited
Loading

@Juan-EBI
Copy link
Contributor Author

@jhoanmanuelms as Fire ignores slash prefix instead of fixing this manually we are basically sending paths without it.

@Juan-EBI Juan-EBI requested a review from jhoanmanuelms May 26, 2023 15:13
jhoanmanuelms
jhoanmanuelms approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@jhoanmanuelms jhoanmanuelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Juan-EBI Juan-EBI merged commit a595add into master May 30, 2023
@Juan-EBI Juan-EBI deleted the feature/pivotal-185273996-Fire-s3-path-should-be-relative branch May 30, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoanmanuelms jhoanmanuelms jhoanmanuelms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Juan-EBI @jhoanmanuelms