Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 183230982: Avoid Special Characters In File Paths #713

Merged
merged 2 commits into from
May 30, 2023

Conversation

jhoanmanuelms
Copy link
Contributor

https://www.pivotaltracker.com/story/show/183230982

This is the initial PR just to move all the logic into a single package so we have everything in the same place. The plan is:

  1. This PR to re-structure everything
  2. Refactor out the database method used to query files from the database into a separate class so we have the database access as isolated as possible. I know having db access here is not ideal but I think removing the need for it is out of the scope of this ticket
  3. Create a class that works as single entry point for the files and use only this one. All the other implementations should be internal
  4. Finally, apply the validation for the file path in this single entry point

The changes contained in this PR are:

  • Create a new module in order to contain all the file sources related logic
  • Refactor all the file sources related logic and tests into the new module
  • Remove unused code

- Create a new module in order to contain all the file sources related logic
- Refactor all the file sources related logic and tests into the new module
- Remove unused code
@jhoanmanuelms jhoanmanuelms self-assigned this May 25, 2023
@jhoanmanuelms jhoanmanuelms requested a review from Juan-EBI May 25, 2023 17:23
Copy link
Contributor

@Juan-EBI Juan-EBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor

@jhoanmanuelms jhoanmanuelms merged commit 9b7343d into master May 30, 2023
@jhoanmanuelms jhoanmanuelms deleted the bugfix/pivotal-#183230982-file-sources-refactor branch May 30, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants