Pivotal ID # 184822139: Delete Submission Folder After Resubmission #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
approved these changes
May 11, 2023
| private val submissionPersistenceService: SubmissionPersistenceService, | ||
| private val submissionRequestFinalizer: SubmissionRequestFinalizer, |
There was a problem hiding this comment.
I don't like very much the idea of including the SubmissionRequestFinalizer here since it's part of the submission workflow
| deleteRemainingFiles(null, submission) | ||
| } | ||
|
|
||
| private fun deleteRemainingFiles(current: ExtSubmission?, previous: ExtSubmission) { |
There was a problem hiding this comment.
I think this is the logic that should be moved to the FileStorageService and then be used in both places since it makes more sense to me to have a storage services that deletes files that later is used by both, the RequestFinalizer and the SubmissionService than the SubmissionService using the RequestFinalizer directly
Juan-EBI
deleted the
feature/pivotal-184822139-Delete-submission-folder-after-resubmission
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/184822139