Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 184779579: Match generated zip with user folders Collapse #703

Conversation

Juan-EBI
Copy link
Contributor

@Juan-EBI Juan-EBI commented May 2, 2023

https://www.pivotaltracker.com/story/show/184779579

  • added file type to serialization

@Juan-EBI
Copy link
Contributor Author

Juan-EBI commented May 2, 2023

@jhoanmanuelms main change here is that we will use file type attribute to search for directories with the same name in user folder when re submitting in this case we "detect" any change there when re submitting.

@Juan-EBI Juan-EBI requested a review from jhoanmanuelms May 4, 2023 09:13
Copy link
Contributor

@jhoanmanuelms jhoanmanuelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


fun getFile(path: String): File?
fun getFileList(path: String): File?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a specific operation for the file lists?

@Juan-EBI Juan-EBI merged commit e7cda44 into master May 16, 2023
@Juan-EBI Juan-EBI deleted the feature/pivotal-184779579-Match-generated-zip-with-user-folders branch May 17, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants