Pivotal ID # 184812856: Regenerate pagetab operation #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
approved these changes
Apr 25, 2023
| @@ -92,6 +92,7 @@ interface SubmissionDraftRepository : MongoRepository<DocSubmissionDraft, String | |||
| } | |||
|
|
|||
| interface FileListDocFileRepository : MongoRepository<FileListDocFile, ObjectId> { | |||
| @Meta(cursorBatchSize = 100, flags = [CursorOption.NO_TIMEOUT]) | |||
| return ExtFileTable(files.toList()) | ||
| } | ||
|
|
||
| fun getReferencedFile(accNo: String, fileListName: String): Sequence<ExtFile> { |
There was a problem hiding this comment.
I think this should be called getReferencedFilesAsSequece or getReferencedFilesSequece since the only difference is the returned type and the current name (singular) gives the impression that this method is used to get a single file
Also, I know there're some places in the code were we use the function above (getReferencedFiles) just to get the list. I mean, we're calling the function, getting an ExtFileTable object, and then getting the list. Maybe it would be worth taking a look at these since it might make more sense to use this new function that returns a sequence and consume it accordingly.
| fun asTsv( | ||
| @PathVariable accNo: String, | ||
| @PathVariable fileList: String, | ||
| ): ResponseEntity<Resource> = fileListFile(accNo, fileList, SubFormat.TSV) |
Juan-EBI
deleted the
feature/pivotal-184812856-Regenerate-pagetab-operation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/184812856