Pivotal ID # 184772659: Delete only common files when required on re submission #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juan-EBI
commented
Mar 22, 2023
| val newFiles = newFilesMap(new) | ||
| logger.info { "${current.accNo} ${current.owner} Started cleaning common submission files" } | ||
| serializationService.fileSequence(current) | ||
| .filter { newFiles.containsKey(it.filePath) && newFiles[it.filePath] != it.md5 } | ||
| .filter { shouldDelete(newFiles, it) } |
There was a problem hiding this comment.
previous mechanism delete file regardless if the storage type is the same or not resulting in deletion of importants files as page tab ones.
| @@ -28,7 +30,6 @@ class SubmissionRequestCleaner( | |||
| if (current != null) { | |||
| logger.info { "${new.accNo} ${new.owner} Started cleaning common files of version ${new.version}" } | |||
| deleteCommonFiles(new, current) | |||
| storageService.deleteFtpLinks(current) | |||
There was a problem hiding this comment.
previos changes deleted all ftp folder resulting in files unavaialbiltiy even when not need it.
Juan-EBI
deleted the
feature/pivotal-184772659-Delete-only-common-files-when-required-on-re-submission
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/184772659