Pivotal ID # 183688670: Structure Backend Notifications #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Submit notifications independently for PMC / scheduler notifications - Remove "failed log" queues - Remove unused code
Juan-EBI
approved these changes
Apr 25, 2023
| @@ -22,3 +24,8 @@ class DailyScheduling { | |||
| var releaser: Boolean = true | |||
| var exporter: Boolean = true | |||
| } | |||
|
|
|||
| class SlackConfiguration { | |||
There was a problem hiding this comment.
spring boot now support data class for configuration classes. So we can avoid the use latenit and use dataclass constructor binding. Check ApplicationProperties
| @@ -6,7 +6,7 @@ import org.springframework.http.MediaType.APPLICATION_JSON | |||
| import org.springframework.web.client.RestTemplate | |||
| import org.springframework.web.client.postForEntity | |||
|
|
|||
| class NotificationsSender( | |||
| open class NotificationsSender( | |||
There was a problem hiding this comment.
I think rather than introduce extra classes and inhirantece we can use Spring @Qualifer to tag each bean diferently.
- Use Qualifier instead of inheritance - Use ConstructorBinding for the application properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/183688670