Pivotal ID # 184485190: S3 Client For FIRE Download Operations #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
requested changes
Mar 1, 2023
| ): File? = findByPath(path)?.let { | ||
| downloadFireFile(path.substringAfterLast("/"), "/objects/blob/path/$path") | ||
| ): File? { | ||
| return downloadFireFile(path.substringAfterLast("/"), "/objects/blob/path/$path") |
There was a problem hiding this comment.
I don't think this change will solve the issue since this endpoint will also be removed. Check this slack thread for more info.
There was a problem hiding this comment.
yes I am aware of this, but I prefer to change to path and then s3 than a single jump (with more changes and risks)
…-services into feature/pivotal-184485190-S3-Client-For-FIRE-Download-Operations
Juan-EBI
deleted the
feature/pivotal-184485190-S3-Client-For-FIRE-Download-Operations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/184485190