Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 184150619: Request retry mechanism #668

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

Juan-EBI
Copy link
Contributor

Copy link
Contributor

@jhoanmanuelms jhoanmanuelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please consider my comment

.forEach { (accNo, version) -> reTriggerSafely(accNo, version) }
}

@Scheduled(cron = "0 0 0/3 * * ?")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the idea is to run this every 3 hours? If so, I think we should use */3 instead of 0/3 which would execute it at the 0 and 3 hours i.e. midnight and 3 am

https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/scheduling/support/CronExpression.html

@Juan-EBI Juan-EBI merged commit e28a0bf into master Jan 16, 2023
@Juan-EBI Juan-EBI deleted the feature/pivotal-184150619-Request-retry-mechanism branch January 16, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants