Pivotal ID # 184014414: Permissions For Resubmission To Collection #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give priority to owner's resubmission
Juan-EBI
approved these changes
Dec 21, 2022
| @@ -184,6 +185,36 @@ class SubmitPermissionTest( | |||
| assertThat(regularUserWebClient.submitSingle(resubmission, SubmissionFormat.TSV)).isSuccessful() | |||
| } | |||
|
|
|||
| @Test | |||
| fun `4-8 owner resubmits without attach permission`() { | |||
There was a problem hiding this comment.
This test is not clear for me, if what we want to test is that "owner resubmits without attach permission" why we are using belhalf client and a imporsonated user in the test. test structure should be something like
- submit with user A in project B
- Remove Attach permission from user A
- Re submit and validate success.
Do am I missing something?
There was a problem hiding this comment.
No, you're not, the test case you're describing is correct. The reason why I added the onbehalf step was to recreate the scenario most used by Ahmed for AE submissions
jhoanmanuelms
deleted the
bugfix/pivotal-#184014414-resubmit-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/184014414
Give priority to owner's resubmission