Pivotal ID # 183126684: Log Submission Draft ID #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include draft related information in the logs - Change the logging level for the retry web template from error to warning
Juan-EBI
reviewed
Dec 6, 2022
| @@ -65,16 +65,26 @@ class SubmissionSubmitter( | |||
| try { | |||
| logger.info { "${rqt.accNo} ${rqt.owner} Started processing submission request" } | |||
|
|
|||
| rqt.draftKey?.let { draftService.setProcessingStatus(rqt.owner, it) } | |||
| rqt.draftKey?.let { | |||
There was a problem hiding this comment.
I think this is adding too much complexity to this method, we times the same conditional (if draftkey != null) in this few lines. Not really sure about but we may consider include accNo and owner in draftService operations to log on each status change. Not much better as we will be including parameters only for logging purposes but as it is righ it looks super verbose.
Juan-EBI
reviewed
Dec 6, 2022
| val processed = submissionProcessor.processSubmission(rqt) | ||
| parentInfoService.executeCollectionValidators(processed) | ||
| rqt.draftKey?.let { draftService.setAcceptedStatus(it) } | ||
| rqt.draftKey?.let { | ||
| logger.info { "${rqt.accNo} ${rqt.owner} Assigned accNo '${processed.accNo}' to draft with key '$it'" } |
There was a problem hiding this comment.
this one I can guess can be moved to submissionProcessor.processSubmission where actuallty this happens (I am looking for way to reduce verbosity here )
Juan-EBI
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/183126684