Pivotal ID # 183324114: Decouple Request Files #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Decouple files for the releasing operation - Move the files iteration to the release processor - Normalize processor classes names - Improve name for the files persistence configuration
Juan-EBI
approved these changes
Oct 5, 2022
| @@ -146,21 +146,22 @@ internal object FileUtilsHelper { | |||
| } | |||
|
|
|||
| fun createFolderHardLinks( | |||
| source: Path, | |||
| target: Path, | |||
| sourcePath: Path, | |||
There was a problem hiding this comment.
any reason to change names here? I mean is not that I disagree with name change but trying to figured out the reasoning.
There was a problem hiding this comment.
It's just to make it clearer that the source is the path where the hard link will be created and not the referenced file itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/183324114