Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 180178872: ORCID is ignored #578

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

jhoanmanuelms
Copy link
Contributor

https://www.pivotaltracker.com/story/show/180178872

  • Rename auxProfile column to orcid
  • Store/fetch ORCID in the user profile

- Rename auxProfile column to orcid
- Store/fetch ORCID in the user profile
@jhoanmanuelms jhoanmanuelms self-assigned this Jun 27, 2022
@jhoanmanuelms jhoanmanuelms requested a review from Juan-EBI June 27, 2022 16:22
Copy link
Contributor

@Juan-EBI Juan-EBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please check comment, also we need to migrate old data before releasing this one. Maybe we can have script ready.

@@ -47,7 +47,7 @@ CREATE TABLE User
id BIGINT AUTO_INCREMENT PRIMARY KEY,
activationKey VARCHAR(255) NULL,
active BIT NOT NULL,
auxProfileInfo LONGTEXT NULL,
orcid LONGTEXT NULL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longtext does not look appropiated for this. VARCHAR(255) should be enought.

Use varchar instead of longtext for the orcid
@jhoanmanuelms jhoanmanuelms merged commit 0abf93d into master Jun 28, 2022
@jhoanmanuelms jhoanmanuelms deleted the bugfix/pivotal-#180178872-orcid-is-ignored branch June 28, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants