Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivotal ID # 182221666: FIRE Single File Persistence #565

Merged
merged 2 commits into from
May 19, 2022

Conversation

jhoanmanuelms
Copy link
Contributor

https://www.pivotaltracker.com/story/show/182221666

  • Calculate the MD5 at persistence time rather than when loading the request
  • Simplify the submission request loading
  • Add content to the integration tests files to cover the scenario with multiple MD5
  • Remove unused code

- Calculate the MD5 at persistence time rather than when loading the request
- Simplify the submission request loading
- Add content to the integration tests files to cover the scenario with multiple MD5
- Remove unused code
@jhoanmanuelms jhoanmanuelms self-assigned this May 19, 2022
@jhoanmanuelms jhoanmanuelms requested a review from Juan-EBI May 19, 2022 12:40
Calculate the files properties when te request is read
Copy link
Contributor

@JuanCamiloRada JuanCamiloRada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great changes. LGTM

@jhoanmanuelms jhoanmanuelms merged commit a26fe30 into master May 19, 2022
@jhoanmanuelms jhoanmanuelms deleted the bugfix/pivotal-182221666-fire-file-persistence branch May 19, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants