Pivotal ID # 181636957: FIRE: Retry File Persistence #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
approved these changes
May 18, 2022
|
|
||
| class FireClientFactory private constructor() { | ||
| companion object { | ||
| fun create(tmpDirPath: String, config: FireConfig): uk.ac.ebi.fire.client.integration.web.FireClient { |
There was a problem hiding this comment.
I understand the change from FireOperations to FireClient, it makes a lot of sense now that we'll have multiple clients implementations however, I think we should rename the uk.ac.ebi.fire.client.api.FireClient implementation class so we don't have confusions and we don't need to use full imports in the code.
I think the name we had before, FireWebClient still would make sense or even WebFireClient
|
|
||
| @Suppress("TooManyFunctions") | ||
| internal class RetryWebClient( | ||
| private val fileOperations: FireClient, |
There was a problem hiding this comment.
I think it'd be much clearer to call this parameter just fireClient, specially after changing the interface name
| password = properties.fire.password | ||
| ), | ||
| RetryConfig( | ||
| maxAttempts = 20, |
There was a problem hiding this comment.
Should we make these values configurable?
jhoanmanuelms
deleted the
feature/pivotal-181636957-FIRE-Retry-File-Persistence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/181636957